Akiba So
3295018ee3
All checks were successful
CI / Windows build (push) Successful in 11m34s
W1 — Custom pen width + pressure sensitivity (Saber-style):
- Root cause of "压感没用": perfect_freehand 1.0.4 IGNORES real stylus pressure
(hardcodes radius=size/2 when simulatePressure=false) — width never tracked pen
force. Upgraded perfect_freehand ^1.0.0 -> ^2.0.0 (honors real pressure); migrated
all 5 getStroke call sites to the 2.x API (PointVector / StrokeOptions / Offset).
- De-hardcoded `thinning` into `kDefaultPenThinning` (0.85), single source shared by
the on-screen painter and the PDF export path; exposed as PenConfig.pressureSensitivity
with a Pressure Sensitivity slider; live-applies via a config listener.
W3 — Native Windows pen plugin (tilt + barrel/eraser buttons):
- windows/runner/pen_channel.{h,cpp}: observe WM_POINTER at the TOP of MessageHandler
(before HandleTopLevelWindowProc, which Flutter uses to consume pen events), read
GetPointerPenInfo penFlags + tilt, stream over EventChannel('badnote/pen'); non-consuming.
- PenInputService: single latched hardware state (no Win32-pointerId<->event.pointer
correlation); graceful no-op off-Windows.
- pen_canvas maps barrel/inverted/eraser through PenConfig.sideButton/eraserEnd
(eraser/undo/toggleTool/pan) and captures tilt into PenPoint.tilt -> EditorPoint.tilt.
W2 — Zoom flicker: page raster isolated in its own RepaintBoundary (safe interim);
definitive crisp-on-zoom fix gated on the on-device root-cause probe (plan M3).
Plans: ralplan-consensus plan at docs/plans/2026-06-22-badnote-pen-polish.md
(Architect APPROVE-WITH-MUST-FIX M1-M4 + Critic ITERATE->APPROVE).
Tests: 58/58 pass incl. shared-thinning invariant + thinning-affects-outline +
tilt-adapter round-trip. flutter analyze clean; linux debug build OK.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
88 lines
3.0 KiB
Dart
88 lines
3.0 KiB
Dart
// test/pen_config_test.dart
|
|
//
|
|
// Unit tests for PenConfig (toJson/fromJson round-trip) and
|
|
// applyPressureCurve. No widgets, no SharedPreferences, no Flutter framework.
|
|
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:badnote/editor/engine/stroke_geometry.dart'
|
|
show kDefaultPenThinning;
|
|
import 'package:badnote/editor/input/pen_config.dart';
|
|
|
|
void main() {
|
|
group('applyPressureCurve', () {
|
|
test('gamma=1 is identity', () {
|
|
expect(applyPressureCurve(0.5, 1.0), closeTo(0.5, 1e-9));
|
|
expect(applyPressureCurve(0.0, 1.0), closeTo(0.0, 1e-9));
|
|
expect(applyPressureCurve(1.0, 1.0), closeTo(1.0, 1e-9));
|
|
});
|
|
|
|
test('applyPressureCurve(0.5, 2.0) == 0.25', () {
|
|
expect(applyPressureCurve(0.5, 2.0), closeTo(0.25, 1e-9));
|
|
});
|
|
|
|
test('clamps input below 0', () {
|
|
expect(applyPressureCurve(-0.5, 1.0), closeTo(0.0, 1e-9));
|
|
});
|
|
|
|
test('clamps input above 1', () {
|
|
expect(applyPressureCurve(1.5, 1.0), closeTo(1.0, 1e-9));
|
|
});
|
|
});
|
|
|
|
group('PenConfig toJson / fromJson round-trip', () {
|
|
test('default config survives round-trip', () {
|
|
const original = PenConfig();
|
|
final restored = PenConfig.fromJson(original.toJson());
|
|
expect(restored, equals(original));
|
|
});
|
|
|
|
test('custom config survives round-trip', () {
|
|
const original = PenConfig(
|
|
sideButton: PenButtonAction.undo,
|
|
eraserEnd: PenButtonAction.pan,
|
|
pressureGamma: 1.5,
|
|
palmRejectionMs: 200.0,
|
|
fingerDrawing: true,
|
|
penWidth: 0.008,
|
|
highlighterWidth: 0.03,
|
|
pressureSensitivity: 0.42,
|
|
);
|
|
final restored = PenConfig.fromJson(original.toJson());
|
|
expect(restored, equals(original));
|
|
expect(restored.pressureSensitivity, 0.42);
|
|
});
|
|
|
|
test('fromJson falls back to defaults for missing keys', () {
|
|
final restored = PenConfig.fromJson({});
|
|
expect(restored.sideButton, PenButtonAction.eraser);
|
|
expect(restored.eraserEnd, PenButtonAction.eraser);
|
|
expect(restored.pressureGamma, 1.0);
|
|
expect(restored.palmRejectionMs, 150.0);
|
|
expect(restored.fingerDrawing, false);
|
|
expect(restored.penWidth, 0.004);
|
|
expect(restored.highlighterWidth, 0.02);
|
|
// Missing pressureSensitivity defaults to the shared thinning constant,
|
|
// preserving the pre-existing stroke feel + export golden (plan M4).
|
|
expect(restored.pressureSensitivity, kDefaultPenThinning);
|
|
});
|
|
|
|
test('fromJson falls back to defaults for unknown enum names', () {
|
|
final restored = PenConfig.fromJson({
|
|
'sideButton': 'unknownAction',
|
|
'eraserEnd': 'anotherUnknown',
|
|
});
|
|
expect(restored.sideButton, PenButtonAction.eraser);
|
|
expect(restored.eraserEnd, PenButtonAction.eraser);
|
|
});
|
|
});
|
|
|
|
group('PenConfig copyWith', () {
|
|
test('copyWith preserves unchanged fields', () {
|
|
const original = PenConfig(pressureGamma: 2.0);
|
|
final copy = original.copyWith(fingerDrawing: true);
|
|
expect(copy.pressureGamma, 2.0);
|
|
expect(copy.fingerDrawing, true);
|
|
});
|
|
});
|
|
}
|