Files
BadNote/server/badnote_server/routers/notes_router.py
Akiba So 72428dc075
Some checks failed
CI / Test (Server, optional) (push) Failing after 2m10s
Windows Build / Build Windows (x64) (push) Failing after 29s
CI / Test (Flutter, Linux) (push) Has been cancelled
CI / Analyze (Flutter) (push) Has been cancelled
Fix bugs across app + server, optimize UI/UX, add Gitea CI
Bug fixes (Flutter):
- Wrap multi-statement DB writes (insert/update/delete note, deleteDocument,
  deletePageData, OCR FTS merge, migrations) in transactions to prevent data
  loss on interruption and a read-modify-write FTS race.
- Fix PdfDocument leaks on exception (try/finally dispose) and preserve image
  aspect ratio when stamping images onto PDF pages.
- Guard file-picker against empty selection (was .single -> crash).
- Fix eraser ConcurrentModificationError and unmodifiable-list crash on PDF
  pages; capture page synchronously on save to stop wrong-page data loss.
- Fix Riverpod DB-not-ready races, broken pull-to-refresh, settings load race,
  and search N+1; transform stored annotations on PDF page rotation.
- Normalize pen pressure for devices without a pressure range.
- PPT: single source of truth for slide strokes so ink displays and exports.

UI/UX:
- Material 3 typography, theme-aware colors (dark-mode fixes), hover cursors
  and right-click/visible actions on desktop, keyboard shortcuts (undo/redo/
  save/find), toolbar overflow handling, friendlier empty states, semantic OCR
  status badges, relative timestamps, 1-based page indicators, large-deck PPT
  navigation, and a scratchpad-scope label in split view.

Server (optional backend):
- Persist JWT secret (was per-process random), block path traversal in storage,
  fix CORS '*'+credentials, add OCR job ownership checks, last-writer-wins sync
  guard, constant-time login, and split out heavy OCR deps so the API/tests run
  without them.

CI: Gitea workflows for format+analyze+test (Linux, system sqlite) and a
Windows release build; pristine `flutter analyze`, all Flutter and server tests
green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-21 03:18:00 +08:00

118 lines
3.7 KiB
Python

"""Notes CRUD router for BadNote."""
import json
from datetime import datetime, timezone
from uuid import uuid4
from fastapi import APIRouter, Depends, HTTPException, Query, status
from ..auth import get_current_user
from ..database import get_db
from ..models import NoteCreate, NoteResponse, NoteUpdate
router = APIRouter()
def _row_to_note(row) -> NoteResponse:
return NoteResponse(
id=row["id"],
user_id=row["user_id"],
title=row["title"],
created_at=row["created_at"],
updated_at=row["updated_at"],
tags=json.loads(row["tags"]),
strokes_json=row["strokes_json"],
)
@router.get("", response_model=list[NoteResponse])
async def list_notes(
since: str | None = Query(None, description="ISO8601 timestamp filter"),
user_id: str = Depends(get_current_user),
) -> list[NoteResponse]:
"""List notes, optionally filtered by updated_at > since."""
db = await get_db()
if since:
cursor = await db.execute(
"SELECT * FROM notes WHERE user_id = ? AND updated_at > ? ORDER BY updated_at",
(user_id, since),
)
else:
cursor = await db.execute(
"SELECT * FROM notes WHERE user_id = ? ORDER BY updated_at",
(user_id,),
)
rows = await cursor.fetchall()
return [_row_to_note(r) for r in rows]
@router.get("/{note_id}", response_model=NoteResponse)
async def get_note(
note_id: str,
user_id: str = Depends(get_current_user),
) -> NoteResponse:
"""Get a single note by ID."""
db = await get_db()
cursor = await db.execute(
"SELECT * FROM notes WHERE id = ? AND user_id = ?", (note_id, user_id)
)
row = await cursor.fetchone()
if row is None:
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Note not found")
return _row_to_note(row)
@router.post("", response_model=NoteResponse, status_code=status.HTTP_201_CREATED)
async def upsert_note(
body: NoteCreate,
user_id: str = Depends(get_current_user),
) -> NoteResponse:
"""Create or update a note (upsert by id)."""
db = await get_db()
now = datetime.now(timezone.utc).isoformat()
tags_json = json.dumps(body.tags)
existing = await (
await db.execute(
"SELECT id FROM notes WHERE id = ? AND user_id = ?", (body.id, user_id)
)
).fetchone()
if existing:
await db.execute(
"""UPDATE notes SET title = ?, tags = ?, strokes_json = ?, updated_at = ?
WHERE id = ? AND user_id = ?""",
(body.title, tags_json, body.strokes_json, now, body.id, user_id),
)
else:
await db.execute(
"""INSERT INTO notes (id, user_id, title, created_at, updated_at, tags, strokes_json)
VALUES (?, ?, ?, ?, ?, ?, ?)""",
(body.id, user_id, body.title, now, now, tags_json, body.strokes_json),
)
await db.commit()
cursor = await db.execute(
"SELECT * FROM notes WHERE id = ? AND user_id = ?", (body.id, user_id)
)
row = await cursor.fetchone()
return _row_to_note(row)
@router.delete("/{note_id}", status_code=status.HTTP_200_OK)
async def delete_note(
note_id: str,
user_id: str = Depends(get_current_user),
) -> dict:
"""Delete a note."""
db = await get_db()
cursor = await db.execute(
"SELECT id FROM notes WHERE id = ? AND user_id = ?", (note_id, user_id)
)
if await cursor.fetchone() is None:
raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail="Note not found")
await db.execute("DELETE FROM notes WHERE id = ? AND user_id = ?", (note_id, user_id))
await db.commit()
return {"deleted": note_id}